test: Add pytest-xdist to execute tests in parallel on CI (and/or locally)#2672
Conversation
github-actions
Bot
added
the
type:documentation
|
@mpangrazzi thanks for this 👍🏽 Could you quickly check if in our tests that depend on hosted instances, each (os/python version) is using a unique index name, those are the hosted doc stores:
|
|
@davidsbatista I would first use this approach on any IT tests which don't use hosted instances, since it's easier to detect issues (if any). For instance, I think it could be applied safely also to ES integration. For others, I would do that without hurry, when one has the chance to work on an integration which has relatively slow tests. WDYT? cc @anakin87 |
agree: ElasticSearch, OpenSearch and Qdrant are all good candidates - high usage and can all run locally |
anakin87
changed the title
pytest-xdist to execute tests in parallel on CI (and/or locally)pytest-xdist to execute tests in parallel on CI (and/or locally)
| from haystack_integrations.document_stores.opensearch.document_store import OpenSearchDocumentStore | ||
|
|
||
|
|
||
| def _get_unique_index_name(request) -> str: |
There was a problem hiding this comment.
could we simplify this? I am thinking of generating a UUID or something similar.
There was a problem hiding this comment.
Done. I initially though that having the test name as the index name may help. But on a second though, we can also use an UUID without issues.
3 participants
Proposed Changes:
I've added
pytest-xdistwhich distributes tests on N different workers for faster execution. On my Mac M3 Pro I can get tests executed ~75% faster. (35s vs 2m 15s on avg).How did you test it?
unit tests, integration tests
Notes for the reviewer
By default, tests will be still run serially. To run them concurrently, you must add
-noption. For example:Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.